Build/Test Tools: Extend the PHPUnit runner variable to the v1 and v2 workflows - #12847
Closed
lancewillett wants to merge 1 commit into
Closed
Build/Test Tools: Extend the PHPUnit runner variable to the v1 and v2 workflows#12847lancewillett wants to merge 1 commit into
lancewillett wants to merge 1 commit into
Conversation
… workflows. [62891] added the `runs-on` override to `reusable-phpunit-tests-v3.yml` alone, so only branches calling that workflow can be redirected. Branches 4.7 through 5.1 call `reusable-phpunit-tests-v1.yml` and branches 5.2 through 5.8 call `reusable-phpunit-tests-v2.yml`, both at `@trunk`. Neither workflow reads the variable, so a repository or organization variable has no effect on those twelve branches. This applies the same one-line change to both. With `RUNNERS_NAME` unset, jobs run on `inputs.os` exactly as before, so there is no change by default. Fixes #65749.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced Aug 5, 2026
pento
pushed a commit
that referenced
this pull request
Aug 7, 2026
… workflows. This commit extends r62891 to the two older reusable PHPUnit workflows. That change added the `runs-on` override to `reusable-phpunit-tests-v3.yml` alone, so only branches calling that workflow can be redirected. Branches 4.7 through 5.1 call `reusable-phpunit-tests-v1.yml`, and branches 5.2 through 5.8 call `reusable-phpunit-tests-v2.yml`, both at `@trunk`. Neither reads the variable, so setting `RUNNERS_NAME` at the repository or organization level has no effect on those twelve branches. This applies the same one-line change to both files. With the variable unset, jobs run on `inputs.os` exactly as before, so there is no change by default. Each of the three reusable PHPUnit workflows contains exactly one `runs-on`, so no other line in these files needs the same treatment. Developed in #12847. Follow-up to r62891, r62974, r63003. Props lancewillett. Fixes #65749. git-svn-id: https://develop.svn.wordpress.org/trunk@63159 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Aug 7, 2026
… workflows. This commit extends r62891 to the two older reusable PHPUnit workflows. That change added the `runs-on` override to `reusable-phpunit-tests-v3.yml` alone, so only branches calling that workflow can be redirected. Branches 4.7 through 5.1 call `reusable-phpunit-tests-v1.yml`, and branches 5.2 through 5.8 call `reusable-phpunit-tests-v2.yml`, both at `@trunk`. Neither reads the variable, so setting `RUNNERS_NAME` at the repository or organization level has no effect on those twelve branches. This applies the same one-line change to both files. With the variable unset, jobs run on `inputs.os` exactly as before, so there is no change by default. Each of the three reusable PHPUnit workflows contains exactly one `runs-on`, so no other line in these files needs the same treatment. Developed in WordPress/wordpress-develop#12847. Follow-up to r62891, r62974, r63003. Props lancewillett. Fixes #65749. Built from https://develop.svn.wordpress.org/trunk@63159 git-svn-id: http://core.svn.wordpress.org/trunk@62358 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends r62891 to the two older reusable PHPUnit workflows.
That change added the
runs-onoverride toreusable-phpunit-tests-v3.ymlalone, so only branches calling that workflow can be redirected.Branches 4.7 through 5.1 call
reusable-phpunit-tests-v1.yml, and branches 5.2 through 5.8 callreusable-phpunit-tests-v2.yml, both at@trunk. Neither reads the variable, so settingRUNNERS_NAMEat the repository or organization level has no effect on those twelve branches.This applies the same one-line change to both files. With the variable unset, jobs run on
inputs.osexactly as before, so there is no change by default.Each of the three reusable PHPUnit workflows contains exactly one
runs-on, so no other line in these files needs the same treatment.Trac ticket: https://core.trac.wordpress.org/ticket/65749
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5
Used for: Identifying the gap by comparing which branches call which reusable workflow, drafting the two-line change, and drafting this description. Reviewed and verified by me before opening.